Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vis: tree display: fix balancer nodes not spanning the entire height they should #1510

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Mar 16, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Mar 16, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.2882%. Comparing base (441c9e8) to head (6864d77).

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1510   +/-   ##
===========================================
  Coverage   56.2882%   56.2882%           
===========================================
  Files           164        164           
  Lines         24856      24856           
  Branches       1435       1435           
===========================================
  Hits          13991      13991           
  Misses        10811      10811           
  Partials         54         54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 16, 2024

Passing run #1328 ↗︎

0 75 1 0 Flakiness 0

Details:

Merge 6864d77 into 441c9e8...
Project: OpenTogetherTube Commit: 7a4b45e3da ℹ️
Status: Passed Duration: 04:31 💡
Started: Mar 16, 2024 12:37 PM Ended: Mar 16, 2024 12:42 PM

Review all test suite changes for PR #1510 ↗︎

@dyc3 dyc3 merged commit f24379f into master Mar 16, 2024
22 checks passed
@dyc3 dyc3 deleted the bal-node-pos branch March 16, 2024 13:45
Copy link

cypress bot commented Mar 16, 2024

Passing run #1330 ↗︎

0 75 1 0 Flakiness 0

Details:

vis: tree display: fix balancer nodes not spanning the entire height they should...
Project: OpenTogetherTube Commit: f24379f86f
Status: Passed Duration: 04:05 💡
Started: Mar 16, 2024 1:46 PM Ended: Mar 16, 2024 1:50 PM

Review all test suite changes for PR #1510 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant