add client ids to system state

[Victor-M-Giraldo]

• closes vis: add client ids to system state #1562

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Victor-M-Giraldo]

Still need to actually fix the tests.

[codecov]

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 61.3383%. Comparing base (ba95bdd) to head (9c35f48).
Report is 1 commits behind head on master.

Files	Patch %	Lines
packages/ott-vis/generated.ts	0.0000%	5 Missing ⚠️
packages/ott-vis/types.ts	0.0000%	5 Missing ⚠️
server/generated.ts	0.0000%	5 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1581        +/-   ##
================================================
- Coverage   61.3681%   61.3383%   -0.0298%     
================================================
  Files           167        167                
  Lines         24705      24717        +12     
  Branches       1447       1447                
================================================
  Hits          15161      15161                
- Misses         9488       9500        +12     
  Partials         56         56                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dyc3]

Looking good so far.

[Victor-M-Giraldo]

Don't know if the unit test is really necessary, but I think this ones good.

Edit: maybe not now that I look at the other displays again.

[dyc3]

This is good for ott-vis-panel, but ott-collector and ott-balancer still need to be updated accordingly.

Currently, it seems like the interop between the collector and the panel isn't being enforced in CI. Fixed in #1585

[dyc3]

Whoops, I made some changes earlier today that are conflicting. Sorry about that, I can rebase this for you if you want

[Victor-M-Giraldo]

Whoops, I made some changes earlier today that are conflicting. Sorry about that, I can rebase this for you if you want

Yeah, sure. I tried to do it myself. There is only one conflict but the incoming change is an older version of the buildMonolithTrees which I don't get why.

[dyc3]

Done. This should be pretty easy to finish up

[Victor-M-Giraldo]

Since countRoomClients is returning a map of names to number of clients, I don't think I can access the id for the RegionView and GlobalView.

[dyc3]

Yeah don't worry about global/region view. We're probably going to trash them.

[Victor-M-Giraldo]

Okay, but say if you did want to do that would you change countRoomClients to be like Record<string, ClientState[] or something.

[cypress]

Passing run #1507 ↗︎

0

79

1

0

0

Details:

add client ids to system state (#1581)
Project: OpenTogetherTube	Commit: c15d8f480d
Status: Passed	Duration: 05:20 💡
Started: Apr 3, 2024 7:01 PM	Ended: Apr 3, 2024 7:06 PM

Review all test suite changes for PR #1581 ↗︎

[dyc3]

I would probably leave that count function as is and create a new one.