-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: replace hard coded strings in closed captions control with i18n strings #1589
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1589 +/- ##
================================================
+ Coverage 56.0714% 56.0801% +0.0087%
================================================
Files 166 166
Lines 25200 25205 +5
Branches 1449 1449
================================================
+ Hits 14130 14135 +5
Misses 11014 11014
Partials 56 56 ☔ View full report in Codecov by Sentry. |
2 failed tests on run #1478 ↗︎
Details:
tests/e2e/integration/playback.spec.ts • 2 failed tests • E2E - electronReview all test suite changes for PR #1589 ↗︎ |
2 failed tests on run #1481 ↗︎
Details:
tests/e2e/integration/playback.spec.ts • 2 failed tests • E2E - electronReview all test suite changes for PR #1589 ↗︎ |
No description provided.