Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vis: TopologyView: position subtrees so they don't overlap #1605

Merged

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Apr 4, 2024

No description provided.

Copy link
Owner Author

dyc3 commented Apr 4, 2024

@dyc3 dyc3 mentioned this pull request Apr 4, 2024
Repository owner deleted a comment from coderabbitai bot Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.3757%. Comparing base (ad35b7a) to head (0bc155e).

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1605   +/-   ##
===========================================
  Coverage   61.3757%   61.3757%           
===========================================
  Files           168        168           
  Lines         24816      24816           
  Branches       1458       1458           
===========================================
  Hits          15231      15231           
  Misses         9529       9529           
  Partials         56         56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 4, 2024

Passing run #1516 ↗︎

0 79 1 0 Flakiness 0

Details:

Merge 0bc155e into ad35b7a...
Project: OpenTogetherTube Commit: 0e756c1fa8 ℹ️
Status: Passed Duration: 07:22 💡
Started: Apr 4, 2024 2:58 PM Ended: Apr 4, 2024 3:06 PM

Review all test suite changes for PR #1605 ↗︎

@dyc3 dyc3 marked this pull request as ready for review April 4, 2024 14:48
Copy link
Contributor

coderabbitai bot commented Apr 4, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Owner Author

dyc3 commented Apr 4, 2024

Merge activity

  • Apr 4, 10:49 AM EDT: @dyc3 started a stack merge that includes this pull request via Graphite.
  • Apr 4, 10:57 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 4, 10:59 AM EDT: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'test (20.x)').
  • Apr 4, 11:16 AM EDT: @dyc3 merged this pull request with Graphite.

@dyc3 dyc3 force-pushed the 04-04-vis_add_topologyview branch from d655cc8 to 80f0485 Compare April 4, 2024 14:50
Base automatically changed from 04-04-vis_add_topologyview to master April 4, 2024 14:56
@dyc3 dyc3 force-pushed the 04-04-vis_topologyview_position_subtrees_so_they_don_t_overlap branch from 6b9726a to 0bc155e Compare April 4, 2024 14:57
@dyc3 dyc3 merged commit 2af9b58 into master Apr 4, 2024
23 checks passed
@dyc3 dyc3 deleted the 04-04-vis_topologyview_position_subtrees_so_they_don_t_overlap branch April 4, 2024 15:16
Copy link

cypress bot commented Apr 4, 2024

Passing run #1517 ↗︎

0 79 1 0 Flakiness 0

Details:

vis: TopologyView: position subtrees so they don't overlap (#1605)
Project: OpenTogetherTube Commit: 2af9b58787
Status: Passed Duration: 05:20 💡
Started: Apr 4, 2024 3:18 PM Ended: Apr 4, 2024 3:23 PM

Review all test suite changes for PR #1605 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant