Better Config

[dyc3]

closes #349

This PR overhauls how OTT is configured.

Notable changes

• configs are now .toml files that live in env and they are the preferred way to configure OTT.
  • environment variables should still work
• The POSTGRES_DB_* environment variables are deprecated, and support will be removed some time in the future
  • The new environment vars are more in line with postgres' docker container environment vars.

TODO:

• deprecate old postgres environment vars and print a warning instead of just removing them
• add redis to config schema
• update docker compose files
• remove dotenv
• open a new issue about server-injected feature flags

test plan:

• make sure db migrations still work
• make sure environment vars override config values
• test docker image
• test heroku deployment on staging

[cypress]

Passing run #157 ↗︎

0

52

1

0

0

Details:

Merge a6cd288 into 5b45da5...
Project: OpenTogetherTube	Commit: 5a19acfc95 ℹ️
Status: Passed	Duration: 03:16 💡
Started: May 1, 2023 2:44 PM	Ended: May 1, 2023 2:47 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Merging #849 (a6cd288) into master (a13f39b) will increase coverage by 0.0212%.
The diff coverage is 75.8333%.

@@               Coverage Diff                @@
##             master       #849        +/-   ##
================================================
+ Coverage   60.9984%   61.0196%   +0.0212%     
================================================
  Files            83         83                
  Lines          9515       9533        +18     
  Branches        948        925        -23     
================================================
+ Hits           5804       5817        +13     
- Misses         3711       3716         +5     

Impacted Files	Coverage Δ
server/ott-config.ts	62.0689% <60.7142%> (+2.6486%)	⬆️
server/logger.js	31.8181% <66.6666%> (+3.9112%)	⬆️
server/app.ts	72.5663% <77.2727%> (+4.0979%)	⬆️
server/redisclient.ts	53.2608% <87.5000%> (+1.0869%)	⬆️
server/admin.ts	91.6666% <100.0000%> (+0.7575%)	⬆️
server/api.js	42.7631% <100.0000%> (ø)
server/ffprobe.ts	20.6896% <100.0000%> (-0.4968%)	⬇️
server/infoextractor.ts	63.9593% <100.0000%> (ø)
server/rate-limit.ts	68.4210% <100.0000%> (ø)
server/services/reddit.ts	80.7017% <100.0000%> (+0.3446%)	⬆️
... and 4 more

... and 2 files with indirect coverage changes