chore: disallow null attribute values (open-telemetry#1555)

dyladan · Feb 18, 2021 · f9a2ce0 · f9a2ce0
1 parent 4a4fea0
commit f9a2ce0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/api/src/trace/attributes.ts b/api/src/trace/attributes.ts
@@ -15,12 +15,10 @@
  */
 
 export interface Attributes {
-  [attributeKey: string]: AttributeValue;
+  [attributeKey: string]: AttributeValue | undefined;
 }
 
 export type AttributeValue =
-  | undefined
-  | null
   | string
   | number
   | boolean

diff --git a/api/src/trace/span.ts b/api/src/trace/span.ts
@@ -49,7 +49,7 @@ export interface Span {
    * @param key the key for this attribute.
    * @param value the value for this attribute.
    */
-  setAttribute(key: string, value: AttributeValue): this;
+  setAttribute(key: string, value?: AttributeValue): this;
 
   /**
    * Sets attributes to the span.