Better project finding / opening #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...but skip .git directory
We depend on specific files existing relative to this file so links should be resolved early.
This depends on the unpublished post-v0.11.1 version of dylan-tool, which finds the workspace's default library heuristically if it's not configured. It defaults to the first test library found, and then to the first library of any kind.
Moves all Dylan source files into a sources/ subdirectory, to unclutter the top-level directory and make it easy to find special files like lsp-dylan.el. Renamed a couple of files and moved the top-level loop code into top-level.dylan. lsp-dylan.dylan renamed to handlers.dylan. Might eventually want to separate this out into handle-lifecycle.dylan, handle-workspace.dylan, etc. for the broad groups of handlers.
The `error-handler` argument to `build-project` is required, otherwise handling errors will signal errors. Don't crash if a warning has no source location.
...but not for code that lives in opendylan/sources/lib since those are conceptually independent libraries.
Also moved it to opendylan.dylan since it's mostly about interfacing with the compiler.
Recommended so users can customize it at run-time if desired.
Log the json debug data at the lowest level (send/receive raw message) and always elide most of the textDocument "text" attribute.
Devs should add these options to their emacs init files if they want them.
* Don't open projects until textDocument/didOpen is called. * Be more resilient to errors (but don't yet trigger a build when necessary).
by looking at ../_build
to get newer workspace-default-library-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow-default-library-name:dylan-tool