Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building dylan-test-suite (constants-test) #1105

Open
pedro-w opened this issue Jun 30, 2018 · 2 comments
Open

Error building dylan-test-suite (constants-test) #1105

pedro-w opened this issue Jun 30, 2018 · 2 comments

Comments

@pedro-w
Copy link
Contributor

pedro-w commented Jun 30, 2018

When building the libraries-test-suite-app I get a C compiler error

constants.c:550:22: 
error: integer literal is too large to be represented in any integer type

  T0 = (dylan_value) 0xFFFFFFFFFFFFFFFF8000000000000001L;

from compiling this test code:

define dylan-extensions constant-test $maximum-integer ()
//---*** Add some more tests here...
check-condition("$maximum-integer + 1 overflows",
<error>,
$maximum-integer + 1)
end constant-test $maximum-integer;

There are three parts to this

  1. There's a problem with DFMC's compile-time arithmetic.
  2. This test shouldn't happen at compile-time anyway, it's supposed to test the runtime addition
  3. If the test is made to happen at runtime (easy enough to do) it doesn't raise a condition

I can look into this, but just wanted some opinions first - is this Mac specific or does everyone get this C error? And, on a bigger point, should numerical overflow be raising conditions? At the moment AFAICS it doesn't but implementing it would introduce overhead to many mathematical operations.
Possibly related: #76

@cgay
Copy link
Member

cgay commented Jun 30, 2018

Did you mean #76 ? Also these two seems in the same general area:
#863
#633

@pedro-w
Copy link
Contributor Author

pedro-w commented Jun 30, 2018

I did mean #76. I've edited the original comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants