Bitcode fixes and improvements #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, most bitcode records were written using the write-record function, which iterates through its #rest arguments and calls write-vbr on each. This means that the compiler cannot determine which write-vbr method will be applicable, increasing the dispatch overhead. This change uses a write-record* macro to make significanly more of the arguments in write-vbr calls visible to the compiler's typing mechanism. * sources/lib/llvm/bitcode.dylan (write-record): Factor out the record header writing into write-record-head. (write-record-head): New method for writing out the three VBRs at the beginning of unabbreviated records. (write-record*): New macro for writing unabbreviated records. (%count-operands): New macro for counting write-record* operands. (%write-operands): New macro for writing write-record* operands by expanding into calls to write-vbr. * sources/lib/llvm/llvm-bitcode.dylan: Replace calls to write-record with invocations of write-record* wherever possible. (write-type-record on <llvm-primitive-type>, write-type-record on <llvm-integer-type>,
* sources/lib/llvm/llvm-bitcode.dylan (encode-attribute-list): The proper attribute list encoding for function attributes (AttributeList::FunctionIndex) is #xFFFF_FFFF. The previous encoding ($maximum-unsigned-machine-word on 64-bit platforms) was recognized in some instances but not by the bitcode compatibility upgrade code.
* sources/common-dylan/darwin-common-extensions-helper.c: Add an include of <string.h> to prevent compilation errors due to calls to undeclared strlen().
|
|
||
| // Output the total number of arguments | ||
| let operand-count | ||
| let operand-count :: <integer> |
There was a problem hiding this comment.
It didn’t recognize this was an integer?
There was a problem hiding this comment.
I can't recall if this was needed, or if it was just for documentation purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.