Let execute-component return <component-result>. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increases duplication of calling make to create the result, but it allows for execute-component to do something different to create results unlike the current arrangement. This change lays the ground work for an improvement in how benchmarks are implemented. * run.dylan (maybe-execute-component): Update to create result in skipped case, otherwise, use result returned from executing the component. (execute-component): Change return value to be a result and create and return the result.
cgay
added a commit
that referenced
this pull request
Feb 5, 2016
Let execute-component return <component-result>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases duplication of calling make to create the result,
but it allows for
execute-componentto do something different tocreate results unlike the current arrangement.
This change lays the ground work for an improvement in how
benchmarks are implemented.
(
maybe-execute-component): Update to create result in skippedcase, otherwise, use result returned from executing the component.
(
execute-component): Change return value to be a result andcreate and return the result.