Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in README example #79

Merged
merged 2 commits into from Aug 28, 2018
Merged

Error in README example #79

merged 2 commits into from Aug 28, 2018

Conversation

mrorigo
Copy link
Contributor

@mrorigo mrorigo commented Aug 21, 2018

const parch was used twice in example, assume it's supposed to be const app on second occurrence.

@mrorigo
Error in example
56b031d 
`const parch` was used twice in example, assume it's supposed to be `const app` on second occurrence..
@mrorigo
Merge pull request #1 from mrorigo/readme-error-patch-1
db510fe 
Error in README example
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.387% when pulling db510fe on mrorigo:develop into dac36ed on dylanfoster:develop.

@dylanfoster
Copy link
Owner

thanks for this

@dylanfoster dylanfoster merged commit 4cdf4f4 into dylanfoster:develop Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanfoster dylanfoster dylanfoster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrorigo @coveralls @dylanfoster