Skip to content
This repository has been archived by the owner on Jul 17, 2022. It is now read-only.

Add fail notification hooks before tasks run #41

Closed
wants to merge 1 commit into from
Closed

Add fail notification hooks before tasks run #41

wants to merge 1 commit into from

Conversation

juriejan
Copy link

This will resolve #39 where running a grunt-contrib-watch task with spawn:false would not produce notifications on failure.

I'm not entirely sure if this is the best solution, but it's what I could come up with in a limited amount of time.

I see that there are sample watch tasks in the Grunt configuration file, but I didn't see that they where used in any tests. Perhaps someone can help set these up with some tests. Will see if I can get to it myself when I have time.

@dylang
Copy link
Owner

dylang commented Oct 24, 2013

Interesting, I look forward to trying your solution out.

@juriejan
Copy link
Author

I'm not sure if this will keep adding more hooks to the grunt.fail methods each time a task runs, but on a quick test, it seemed not to.

@juriejan
Copy link
Author

This was also tested with the latest grunt-contrib-watch at the time (0.5.3).

@dylang
Copy link
Owner

dylang commented Oct 29, 2013

I fixed this a different way:
a29474d

@dylang dylang closed this Oct 29, 2013
@juriejan
Copy link
Author

juriejan commented Nov 6, 2013

Awesome! Looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings from grunt-contrib-watch with spawn:false are not displayed.
2 participants