Remove lodash dependency from tasks/prompt.js #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Travis to deprecate testing for pre v8 nodejs
dylang#52 This commit removes lodash from tasks/prompts.js This does not solve the audit alarm issue but helps isolate lodash as much as possible so that the fix can be done incrementally.
mariomui-viscira
force-pushed
the
Remove-lodash-dependency-gradually
branch
from
8a6648d
to
7f6ced2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52
This commit removes lodash from tasks/prompts.js
This does not solve the audit alarm issue but helps isolate lodash as much
as possible so that the fix can be done incrementally.
the isFunction and forEach functions were replaced with vanilla Node alternatives.