Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 - offer templates #29

Merged
merged 7 commits into from
Dec 6, 2022
Merged

6 - offer templates #29

merged 7 commits into from
Dec 6, 2022

Conversation

mhak
Copy link
Collaborator

@mhak mhak commented Nov 15, 2022

Description / Motivation

Partially implements #6.

Created offer service and offer command to retrieve all offer templates or offer templates by Id. Create and update is blocked as the API does not allow updates with a public token.

Added tabSize onto settings.json for better consistency amongst developers

How Has This Been Tested?

tested locally by running both commands

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory or other markdown files)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@mhak mhak linked an issue Nov 15, 2022 that may be closed by this pull request
@mhak mhak removed a link to an issue Nov 15, 2022
@dylanyoung-dev dylanyoung-dev added this to the MVP milestone Nov 18, 2022
@dylanyoung-dev dylanyoung-dev linked an issue Nov 18, 2022 that may be closed by this pull request
@dylanyoung-dev
Copy link
Owner

Looks good, but says the PR is in draft so I can't merge until it's ready to be merged.

@mhak mhak marked this pull request as ready for review November 18, 2022 17:10
@mhak mhak marked this pull request as draft November 18, 2022 19:20
@mhak mhak marked this pull request as ready for review November 18, 2022 19:42
@mhak mhak mentioned this pull request Nov 29, 2022
8 tasks
@mhak mhak merged commit bad13d5 into dev Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support for Offer Templates
2 participants