Skip to content

Commit

Permalink
fix: error out on when even new observe api is used on go and js sdks
Browse files Browse the repository at this point in the history
  • Loading branch information
G4Vi committed Nov 27, 2023
1 parent 21771e6 commit 396ac45
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions go/wasm.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ func parseNames(data []byte) (map[uint32]string, error) {
case "span_enter", "span_tags", "metric", "log", "span_exit":
return nil, errors.New("go sdk does not yet support Observe API")
}
} else if item.Module == "dylibso:observe/api" {
return nil, errors.New("go sdk does not yet support Observe API")
}
}

Expand Down
2 changes: 2 additions & 0 deletions js/src/lib/collectors/span/mod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ export class SpanCollector implements Collector {
if (apiNames.has(iName.name)) {
throw new Error("js sdk does not yet support Observe API");
}
} else if (iName.module === 'dylibso:observe/api') {
throw new Error("js sdk does not yet support Observe API");
}
}
}
Expand Down

0 comments on commit 396ac45

Please sign in to comment.