chore: improve messsaging with incompat wasm-instr versions

dylibso · Nov 9, 2023 · 86cad75 · 86cad75
1 parent a26ad97
commit 86cad75
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/rust/src/context.rs b/rust/src/context.rs
@@ -1,5 +1,5 @@
 use anyhow::{bail, Context, Result};
-use log::{error, warn};
+use log::error;
 use modsurfer_demangle::demangle_function_name;
 use std::{
     collections::HashMap,
@@ -435,7 +435,6 @@ pub fn add_to_linker<T: 'static>(
 
     // check that the version number is supported with this SDK
     if let Err(e) = wasm_instr_info.check_version() {
-        error!("{}", e);
         return Err(e);
     }
     let t = FuncType::new([ValType::I32], []);

diff --git a/rust/src/wasm_instr.rs b/rust/src/wasm_instr.rs
@@ -25,12 +25,14 @@ impl WasmInstrInfo {
         let min_num = self.min_version.unwrap();
 
         if maj_num != WASM_INSTR_VERSION_MAJOR {
-            bail!("wasm wasm-instr major version {maj_num} is not equal to {WASM_INSTR_VERSION_MAJOR}!")
+            bail!("Module wasm_instr_version_major {maj_num} is not equal to {WASM_INSTR_VERSION_MAJOR}!
+Please reinstrument your module with compatible wasm-instr.")
         }
 
         if min_num < WASM_INSTR_VERSION_MINOR {
             bail!(
-                "wasm wasm-instr minor version {min_num} is less than {WASM_INSTR_VERSION_MINOR}!"
+                "Module wasm_instr_version_minor {min_num} is less than {WASM_INSTR_VERSION_MINOR}!
+Please reinstrument your module with the new version of wasm_instr."
             );
         }