fix: go sdk and api updates to latest #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilslice
commented
Feb 28, 2024
bhelx
reviewed
Feb 28, 2024
| @@ -33,6 +33,11 @@ func newTraceCtx(ctx context.Context, eventsChan chan TraceEvent, r wazero.Runti | |||
| return nil, err | |||
| } | |||
|
|
|||
| if opts.ChannelBufferSize == 0 { | |||
| opts.ChannelBufferSize = 64 // set a reasonable minimum here so unset option doesn't block execution on an unbuffered channel | |||
There was a problem hiding this comment.
Just for my clarity, this is a message size and not a byte size right? so 64 messages in the buffer?
There was a problem hiding this comment.
yes, 64 items on the channel until it blocks
There was a problem hiding this comment.
in Go, you call these "buffered channels" which have more than 0 capacity. or "unbuffered channels" which expect the channel to be read immediately unless a write will block. hence the name ChannelBufferSize, which can definitely be confusing if thinking about a more common byte buffer
bhelx
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Go APIs to use the latest names.
Also, without the new check and minimum default setting in
trace_ctx.go, any custom setting to the observe trace config options withoutChannelBufferSizewould use its zero value (0), and would block the SDK from handling events.