Skip to content

Commit

Permalink
attempting fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
dylmye committed May 26, 2023
1 parent 06c99d8 commit 0981c1c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/components/TripItemTypeCard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ const TripItemTypeCard = ({ item, onClick }: Props) => {
onClick={() => onClick(item)}
sx={{
textTransform: "capitalize",
color: "#ffffff",
borderColor: "#ffffff",
color: "palette.action.active",
borderColor: "palette.action.active",
}}>
{friendlyName ?? item}
</Button>
Expand Down
5 changes: 4 additions & 1 deletion src/components/dialogs/AuthenticationModal/SignInContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ const SignInContent = ({ onClose }: AuthModalContentProps) => {
)}
<GoogleSignInButton
alreadyHasAccount
onClick={() => signInWithGoogle([])}
onClick={() => {
signInWithGoogle([]);
onClose(true);
}}
disabled={formLoading}
/>
</Stack>
Expand Down
9 changes: 6 additions & 3 deletions src/components/dialogs/AuthenticationModal/SignUpContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import { AuthModalContentProps } from ".";
// @ts-ignore it only applies to string
YupPassword({ string: yString, addMethod });

type SignupEmailForm = {
interface SignupEmailForm {
/** user id */
email: string;
/** pw to use */
Expand All @@ -52,7 +52,7 @@ type SignupEmailForm = {
checkedPrivacy: boolean;
/** hcaptcha token */
verify?: string;
};
}

/** Firebase Auth-linked Formik form for creating a new account */
const SignUpContent = ({ onClose }: AuthModalContentProps) => {
Expand Down Expand Up @@ -121,7 +121,10 @@ const SignUpContent = ({ onClose }: AuthModalContentProps) => {
)}
<GoogleSignInButton
alreadyHasAccount={false}
onClick={() => signInWithGoogle([])}
onClick={() => {
signInWithGoogle([]);
onClose(true);
}}
/>
</Stack>
<Divider>
Expand Down

0 comments on commit 0981c1c

Please sign in to comment.