Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denomination collisions in AfterDenomMetadataCreation due to case insensitivity #361

Open
omritoptix opened this issue Apr 6, 2024 · 0 comments
Open

Denomination collisions in AfterDenomMetadataCreation due to case insensitivity #361

omritoptix opened this issue Apr 6, 2024 · 0 comments
Assignees
@trinitys7
Labels
wontfix This will not be worked on

Comments

@omritoptix
Copy link
Contributor

omritoptix commented Apr 6, 2024 •
edited by mtsitrin
Loading

In the AfterDenomMetadataCreation function in
evmos:x/erc20/keeper/denom_metadata_hooks.go:34, the validation employs a
case-insensitive comparison (strings.ToLower(newDenomMetadata.Base)) to match
the denomination prefix against the expected IBC prefix. This is problematic because different
casing denominations that are not IBC tokens (e.g., "IbC/..." or "IBc/...") will be treated as
equivalent
@mtsitrin mtsitrin assigned mtsitrin and trinitys7 and unassigned mtsitrin Apr 18, 2024
@omritoptix omritoptix added the wontfix This will not be worked on label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trinitys7 trinitys7

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@omritoptix @zale144 @mtsitrin @trinitys7