Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: UT performance #392

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Nov 6, 2023

PR Standards

Opening a pull request should be able to meet the following requirements:


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner November 6, 2023 12:56
@mtsitrin mtsitrin linked an issue Nov 6, 2023 that may be closed by this pull request
@mtsitrin mtsitrin marked this pull request as draft November 6, 2023 13:18
@mtsitrin mtsitrin marked this pull request as ready for review November 6, 2023 18:22
@mtsitrin mtsitrin merged commit f4e660b into main Nov 6, 2023
2 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/371-ut-takes-long-time-to-run branch November 6, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants