Lowecase read allowed by default #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more `from dynaconf import settings`
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 813 813
=========================================
Hits 813 813 Continue to review full report at Codecov.
|
VaultVulp
reviewed
Jun 16, 2020
Comment on lines
+13
to
+14
| settings = LazySettings(warn_dynaconf_global_settings=True) | ||
|
|
There was a problem hiding this comment.
Suggested change
| settings = LazySettings(warn_dynaconf_global_settings=True) | |
| def __construct_singleton_dynaconf_instance(): | |
| warnings.warn( | |
| "Usage of `from dynaconf import settings` is now " | |
| "DEPRECATED in 3.0.0+. You are encouraged to change it to " | |
| "your own instance e.g: `settings = Dynaconf(*options)`", | |
| DeprecationWarning, | |
| ) | |
| return LazySettings() | |
| settings = __construct_singleton_dynaconf_instance() |
In this case we would not need to change LazySettings class.
There was a problem hiding this comment.
I like that, using a FActory/Builder instead of class state, thanks will change it.
There was a problem hiding this comment.
Sorry, my bad. In this case we will always raise a warning. Even if the user created LazySettings instance, in an adequate way.
There was a problem hiding this comment.
@VaultVulp yes the idea is nice but it is not going to be lazy.
rochacbruno
added a commit
that referenced
this pull request
Jun 22, 2020
Shortlog of commits since last release:
Bernardo Gomes (2):
Adding f string (#319)
Added little information about how dev into this project. (#321)
Bruno Rocha (18):
Release version 3.0.0rc1
Better exception handling on env_loader (#316)
Add support for config aliases (#332)
Add ENVLESS_MODE (#337)
Fix #272 allow access of lowercase keys (#338)
Fix #298 allow auto complete for editors and console (#339)
Vendoring dependencies Fix #301 (#345)
Clean tox installation for local testing (#346)
Validator improvements on conditions (#353)
Add note about quoting in env vars (#347)
DEPRECATED global settings object.
DEPRECATED global settings object. (#356)
Lowecase read allowed by default (#357)
Merge branch 'master' of github.com:rochacbruno/dynaconf
envless by default - breaking change ⚠️ (#358)
dotenv is no more loaded by default (#360)
No more loading of `settings.*` by default (#361)
NO more logger and debug messages (#362)
Douglas Maciel d'Auriol Souza (1):
Insert news validator conditions: (len_eq, len_ne, len_min, len_max, contd) (#328)
Jeff Wayne (1):
s/DYNACONF_ENV/ENV_FOR_DYNACONF (#335)
Marcos Benevides (1):
Fix minor typo in Flask extension docs (#318)
Nicholas Nadeau, Ph.D., P.Eng (1):
Fixed comma typo (#334)
sfunkhouser (1):
Add option to override default mount_point for vault (#349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.