Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed enabled_core_loaders elements to be upper case to fix #455 #457

Merged

Conversation

ilitotor
Copy link
Contributor

I used map and str.upper to transform all string to uppercase and make enabled_core_loaders case sensitive.

@pep8speaks
Copy link

pep8speaks commented Oct 22, 2020

Hello @ilitotor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-23 01:32:18 UTC

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #457 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          847       847           
=========================================
  Hits           847       847           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b560611...7c93965. Read the comment docs.

@ilitotor ilitotor force-pushed the issue_455_fix_core_loaders_lower branch from efe83fd to 4bce241 Compare October 22, 2020 16:46
dynaconf/loaders/__init__.py Outdated Show resolved Hide resolved
dynaconf/loaders/__init__.py Outdated Show resolved Hide resolved
@ilitotor ilitotor force-pushed the issue_455_fix_core_loaders_lower branch from 201ece0 to e037efe Compare October 23, 2020 01:00
@rochacbruno rochacbruno merged commit 69cce9a into dynaconf:master Oct 23, 2020
rochacbruno added a commit that referenced this pull request Mar 1, 2021
Shortlog of commits since last release:

    Bruno Rocha (11):
          Release version 3.1.2
          Fix #445 casting on dottet get. (#446)
          Fix docs regarding --django argument on cli (#477)
          Fix #521 - FlaskDynaconf should raise KeyError for non existing keys (#522)
          Case insensitive envvar traversal (#524)
          Allow load_file to accept pathlib.Path (#525)
          Allow Title case lookup and validation. (#526)
          Fix #482 - formatter case insensitive (#527)
          Fix #449 - Django lazy templating Fix #449 (#528)
          Added a test to reproduce #492 (not able to reproduce) (#530)
          Fix #511 allow user to specify loaders argument to execute_loaders (#531)

    FrankBattaglia (1):
          Specify flask extension initializers by entry point object reference (#456)

    Ilito Torquato (3):
          fix merging hyperlink to fix  #454 (#458)
          Changed enabled_core_loaders elements to be upper case to fix #455 (#457)
          Fix doc secrets from vault #403 (#459)

    Marcelo Lino (1):
          Add __contains__ to Dynaconf (#502)

    Michal Odnous (1):
          Fix: Environment variables filtering #470 (#474)

    dependabot-preview[bot] (5):
          Bump mkdocs-material from 6.0.2 to 6.1.0 (#453)
          Bump mkdocs-git-revision-date-localized-plugin from 0.5.2 to 0.7.3 (#463)
          Bump mkdocs-material from 6.1.0 to 6.1.5 (#473)
          Bump mkdocs-versioning from 0.2.1 to 0.3.1 (#475)
          Bump mkdocs-material from 6.1.5 to 6.1.6 (#476)

    mirrorrim (1):
          Fix reading secret from Vault kv v2 (#483) (#487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants