Fix FlaskConfig.setdefault #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it only checks the underlying dict but not the Dynaconf instance, resulting in the wrong return value if the key exists in the Dynaconf instance.
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1669 1671 +2
=========================================
+ Hits 1669 1671 +2
Continue to review full report at Codecov.
|
rochacbruno
added a commit
that referenced
this pull request
Apr 15, 2022
Shortlog of commits since last release:
Anderson Sousa (1):
Document the usage with python -m (#710)
Andressa Cabistani (2):
Add unique label when merging lists to fix issue #653 (#661)
Add new validation to fix issue #585 (#667)
Armin Berres (1):
Fix typo in error message
Bruno Rocha (7):
Release version 3.1.7
Found this bug that was duplicating the generated envlist (#663)
Add support for Python 3.10 (#665)
Attempt to fix #555 (#669)
Create update_contributors.yml
Fixing pre-coomit and docs CI
Added `dynaconf get` command to cli (#730)
Caneco (2):
improvement: add brand new logo to the project (#686)
improvement: update socialcard to match the python way (#687)
EdwardCuiPeacock (2):
Feature: add @Jinja and @Format casting (#704)
Combo converter doc (#735)
Eitan Mosenkis (1):
Fix FlaskConfig.setdefault (#706)
Enderson Menezes (Mr. Enderson) (2):
Force PYTHONIOENCODING to utf-8 to fix #664 (#672)
edit: move discussions to github tab (#682)
Eugene Triguba (1):
Fix custom prefix link in envvar documentation (#680)
Gibran Herrera (1):
Fix Issue 662 Lazy validation (#675)
Jitendra Yejare (2):
Load vault secrets from environment less stores or which are not written by dynaconf (#725)
Use default value when settings is blank (#729)
Pavel Alimpiev (1):
Update docs link (#678)
Ugo Benassayag (1):
Added validate_only_current_env to validator (issue #734) (#736)
Waylon Walker (1):
Docs Fix Spelling (#696)
dependabot[bot] (3):
Bump django from 2.1.5 to 2.2.26 in /example/django_pytest_pure (#711)
Bump mkdocs from 1.1.2 to 1.2.3 (#715)
Bump django from 2.2.26 to 2.2.27 in /example/django_pytest_pure (#717)
github-actions[bot] (2):
[automated] Update Contributors File (#691)
[automated] Update Contributors File (#732)
lowercase00 (1):
Makes Django/Flask kwargs case insensitive (#721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it only checks the underlying dict but not the Dynaconf instance, resulting in the wrong return value if the key exists in the Dynaconf instance.