Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i take a look at pre-commit config and think some things can be updated to be more clean/organized
The changes:
setup-pre-commit
because the pre-commit will install by default in the first run.--all-files
and keeps the ignore files for the pre-commit (maybe can be used justpre-commit run
here)pre-commit autoupdate
Maybe for other PR the pyupgrade hook can be added to pre-commit to upgrade syntax for newer versions. That can also be used with
from __future__ import annotations
atreorder-python-imports
to update the type annotations.