fix: replace passport dependency with passport-strategy #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericboivin
changed the title
fredericboivin
force-pushed
the
fboivin/deps
branch
3 times, most recently
from
253327b
to
6614e86
Compare
- replace dependency on passport with a dependency on `passport-strat` as its the recommended best pratices - remove this.name from the strategy since it doesn't exist on passport-strategy - remove a few other types that don't exist (StrategyCreated) - fix calls to `this.fail` as the previous usage was inverted challenge/status
fredericboivin
force-pushed
the
fboivin/deps
branch
2 times, most recently
from
3503d71
to
45b54a3
Compare
this was added by default by projen but it's causing problems as running npm i overwrites the yarn.lock changes and vice versa
fredericboivin
force-pushed
the
fboivin/deps
branch
from
45b54a3
to
4cf580f
Compare
yonigoldberg
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 and switch projen to use npm by default instead of yarn