refactor - move labels to lang file (#21)

dynamic · Feb 16, 2019 · 71c2818 · 71c2818
1 parent e90b42f
commit 71c2818
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 28 deletions.
diff --git a/lang/en.yml b/lang/en.yml
@@ -1,9 +1,17 @@
 en:
   Dynamic\Elements\Accordion\Elements\ElementAccordion:
     BlockType: Accordion
+    DESCRIPTION: 'Display content in collapsable panels.'
+    PanelsLabel: Accordion panels
     PLURALNAME: Accordion Elements
     PLURALS:
       one: 'An Accordion Element'
       other: '{count} Accordion Elements'
     SINGULARNAME: Accordion Element
-    PanelsLabel: Accordion panels
+  Dynamic\Elements\Accordion\Model\AccordionPanel:
+    DESCRIPTION: 'A content panel for a Accordion Element'
+    PLURALNAME: Accordion Panels
+    PLURALS:
+      one: 'An Accordion Panel'
+      other: '{count} Accordion Panels'
+    SINGULARNAME: Accordion Panel
diff --git a/src/Elements/ElementAccordion.php b/src/Elements/ElementAccordion.php
@@ -32,11 +32,6 @@ class ElementAccordion extends BaseElement
      */
     private static $table_name = 'ElementAccordion';
 
-    /**
-     * @var string
-     */
-    private static $description = 'Display content in collapsable panels.';
-
     /**
      * @var array
      */

diff --git a/src/Model/AccordionPanel.php b/src/Model/AccordionPanel.php
@@ -26,41 +26,20 @@
  */
 class AccordionPanel extends BaseElementObject
 {
-    /**
-     * @var string
-     */
-    private static $singular_name = 'Accordion Panel';
-
-    /**
-     * @var string
-     */
-    private static $plural_name = 'Accordion Panels';
-
-    /**
-     * @var string
-     */
-    private static $description = 'A panel for a Accordion widget';
-
     /**
      * @var array
      */
     private static $db = [
         'Sort' => 'Int',
     ];
+
     /**
      * @var array
      */
     private static $has_one = [
         'Accordion' => ElementAccordion::class,
     ];
 
-    /**
-     * @var array Related objects to be published recursively on AccordionPanel::publishRecursively()
-     */
-    private static $owns = [
-        'Image',
-    ];
-
     /**
      * @var array Show the panel $Title by default
      */