Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added elements for listing child pages and section navigation #10

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Added elements for listing child pages and section navigation #10

merged 3 commits into from
Oct 27, 2017

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Oct 27, 2017

  • like the ChildPagesBlock and SectionNavigationBlock

Reorganized tests to follow code directory structure

  - like the ChildPagesBlock and SectionNavigationBlock

Reorganized tests to follow code directory structure
@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #10 into master will decrease coverage by 1%.
The diff coverage is 30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
- Coverage     49.45%   48.45%   -1.01%     
- Complexity       57       62       +5     
============================================
  Files             9       11       +2     
  Lines           184      194      +10     
============================================
+ Hits             91       94       +3     
- Misses           93      100       +7
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementChildPages.php 0% <0%> (ø) 1 <1> (?)
src/Elements/ElementSectionNavigation.php 37.5% <37.5%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09dc1bf...88374c6. Read the comment docs.

@mak001 mak001 merged commit d05248e into dynamic:master Oct 27, 2017
@mak001 mak001 deleted the child-section-nav branch October 27, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant