Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion now works on the front end #28

Merged
merged 2 commits into from
Dec 15, 2017
Merged

Accordion now works on the front end #28

merged 2 commits into from
Dec 15, 2017

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Nov 30, 2017

  • uses bootstrap's collapse
  • uses jquery ui's accordion

  - uses bootstrap's collapse
@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #28 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #28      +/-   ##
===========================================
+ Coverage     85.55%   85.6%   +0.05%     
  Complexity       75      75              
===========================================
  Files            17      17              
  Lines           270     271       +1     
===========================================
+ Hits            231     232       +1     
  Misses           39      39
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementAccordion.php 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b84af...1153dc4. Read the comment docs.

@korthjp17
Copy link
Collaborator

I'm wondering if we want to use jquery UI instead of bootstrap as the default accordion. That makes it a bit more universal in case we aren't using BS for the theme. When/if we use something other than BS, it might add some extra load time on the site since it's a bit bulky.

@jsirish any thoughts?

@korthjp17
Copy link
Collaborator

pulled it down and it seems to be working 👍

@jsirish
Copy link
Member

jsirish commented Dec 15, 2017

Ping #33

@jsirish
Copy link
Member

jsirish commented Dec 15, 2017

Just realized this won’t effect #33 so nvm

@jsirish jsirish merged commit f4f8da4 into dynamic:master Dec 15, 2017
@mak001 mak001 deleted the accordion branch January 5, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants