Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementContent - additional fields #43

Merged
merged 1 commit into from
Jan 6, 2018
Merged

ElementContent - additional fields #43

merged 1 commit into from
Jan 6, 2018

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Dec 15, 2017

closes #38

@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #43 into master will increase coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #43      +/-   ##
============================================
+ Coverage     85.39%   85.97%   +0.57%     
- Complexity       72       73       +1     
============================================
  Files            17       18       +1     
  Lines           267      278      +11     
============================================
+ Hits            228      239      +11     
  Misses           39       39
Impacted Files Coverage Δ Complexity Δ
src/Extensions/ElementContentDataExtension.php 100% <100%> (ø) 1 <1> (?)
src/Model/BaseElementObject.php 100% <100%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe317fd...7ea7cb0. Read the comment docs.

@jsirish jsirish merged commit 36ce6e1 into dynamic:master Jan 6, 2018
@jsirish jsirish deleted the bugfix/contentElementFields branch January 6, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Block additions
1 participant