Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/section nav type summary #55

Merged
merged 3 commits into from
Jan 7, 2018
Merged

Bugfix/section nav type summary #55

merged 3 commits into from
Jan 7, 2018

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jan 7, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 7, 2018

Codecov Report

Merging #55 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
+ Coverage      86.2%   86.39%   +0.18%     
- Complexity       77       79       +2     
============================================
  Files            19       19              
  Lines           290      294       +4     
============================================
+ Hits            250      254       +4     
  Misses           40       40
Impacted Files Coverage Δ Complexity Δ
src/Model/AccordionPanel.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Model/PromoObject.php 100% <ø> (ø) 8 <0> (ø) ⬇️
src/Model/GalleryImage.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Model/FeatureObject.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Elements/ElementImage.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Elements/ElementFeatures.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Elements/ElementHero.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Elements/ElementOembed.php 91.66% <ø> (ø) 4 <0> (ø) ⬇️
src/Model/BaseElementObject.php 100% <ø> (ø) 3 <0> (ø) ⬇️
src/Elements/ElementSectionNavigation.php 58.33% <100%> (+20.83%) 6 <2> (+2) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851f2cf...918fba4. Read the comment docs.

@jsirish jsirish merged commit 2310b46 into dynamic:master Jan 7, 2018
@jsirish jsirish deleted the bugfix/sectionNavTypeSummary branch January 7, 2018 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant