Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementCallToAction - migration #56

Merged
merged 2 commits into from
Jan 7, 2018
Merged

ElementCallToAction - migration #56

merged 2 commits into from
Jan 7, 2018

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jan 7, 2018

ping #34

@codecov
Copy link

codecov bot commented Jan 7, 2018

Codecov Report

Merging #56 into master will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #56     +/-   ##
===========================================
+ Coverage      86.2%   86.71%   +0.5%     
- Complexity       77       80      +3     
===========================================
  Files            19       20      +1     
  Lines           290      301     +11     
===========================================
+ Hits            250      261     +11     
  Misses           40       40
Impacted Files Coverage Δ Complexity Δ
src/Model/PromoObject.php 100% <ø> (ø) 8 <0> (ø) ⬇️
src/Elements/ElementHero.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Model/BaseElementObject.php 100% <ø> (ø) 3 <0> (ø) ⬇️
src/Elements/ElementOembed.php 91.66% <ø> (ø) 4 <0> (ø) ⬇️
src/Model/AccordionPanel.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Model/FeatureObject.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Model/GalleryImage.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Elements/ElementImage.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Elements/ElementFeatures.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Elements/ElementCallToAction.php 100% <100%> (ø) 3 <3> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851f2cf...7a49ba5. Read the comment docs.

@jsirish jsirish merged commit 701de73 into dynamic:master Jan 7, 2018
@jsirish jsirish deleted the feature/callToAction branch January 7, 2018 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant