Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed templates for elements being in the wrong place #7

Closed
wants to merge 1 commit into from
Closed

Fixed templates for elements being in the wrong place #7

wants to merge 1 commit into from

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Oct 26, 2017

Fixed naming of templates
Added a Promo template
Fixed Promos erroring

  • temporary fix

Fixed naming of templates
Added a Promo template
Fixed Promos erroring
  - temporary fix
@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

Merging #7 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #7      +/-   ##
===========================================
- Coverage     53.52%   53.3%   -0.22%     
  Complexity       68      68              
===========================================
  Files            10      10              
  Lines           213     212       -1     
===========================================
- Hits            114     113       -1     
  Misses           99      99
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementPromos.php 31.37% <ø> (ø) 16 <0> (ø) ⬇️
src/Model/PromoObject.php 75.75% <100%> (-0.72%) 10 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e982548...2c5c15b. Read the comment docs.

@mak001
Copy link
Contributor Author

mak001 commented Oct 26, 2017

pull #6 is better

@mak001 mak001 closed this Oct 26, 2017
@jsirish
Copy link
Member

jsirish commented Oct 26, 2017

lol sorry @mak001

@mak001 mak001 deleted the bugfix/templates branch November 2, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants