Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementPermissions #71

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Feb 2, 2018

add permissionProvider for Elements and related classes

fixes non-admins not being able to publish pages

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #71 into master will increase coverage by 10.79%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #71       +/-   ##
=============================================
+ Coverage     86.36%   97.16%   +10.79%     
+ Complexity       84       59       -25     
=============================================
  Files            21       23        +2     
  Lines           308      282       -26     
=============================================
+ Hits            266      274        +8     
+ Misses           42        8       -34
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementPromos.php 100% <ø> (+64.15%) 5 <0> (-11) ⬇️
src/Model/PromoObject.php 100% <ø> (ø) 1 <0> (-7) ⬇️
src/Model/FeatureObject.php 100% <ø> (ø) 1 <0> (-4) ⬇️
src/Elements/ElementCustomerService.php 100% <ø> (ø) 3 <0> (ø) ⬇️
src/Model/BaseElementObject.php 100% <ø> (ø) 3 <0> (ø) ⬇️
src/Model/GalleryImage.php 100% <ø> (ø) 1 <0> (-4) ⬇️
src/Model/AccordionPanel.php 100% <ø> (ø) 1 <0> (-4) ⬇️
src/Extensions/ElementPermissions.php 100% <100%> (ø) 1 <1> (?)
src/Extensions/ElementalPermissions.php 100% <100%> (ø) 4 <4> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894b37c...44d1717. Read the comment docs.

@jsirish jsirish force-pushed the feature/baseElementPermissions branch from 267743f to 2021f50 Compare February 2, 2018 16:31
add permissionProvider for Elements and related classes

fixes non-admins not being able to publish pages
@jsirish jsirish force-pushed the feature/baseElementPermissions branch from 2021f50 to 44d1717 Compare February 2, 2018 16:45
@jsirish jsirish merged commit 0d3d4bd into dynamic:master Feb 2, 2018
@jsirish jsirish deleted the feature/baseElementPermissions branch February 2, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant