Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc cleanup #9

Merged
merged 1 commit into from
Oct 27, 2017
Merged

misc cleanup #9

merged 1 commit into from
Oct 27, 2017

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Oct 27, 2017

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #9 into master will decrease coverage by 4.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #9      +/-   ##
============================================
- Coverage     53.52%   49.45%   -4.07%     
+ Complexity       68       57      -11     
============================================
  Files            10        9       -1     
  Lines           213      184      -29     
============================================
- Hits            114       91      -23     
+ Misses           99       93       -6
Impacted Files Coverage Δ Complexity Δ
src/Model/FeatureObject.php 0% <ø> (ø) 7 <0> (ø) ⬇️
src/Elements/ElementBlogPosts.php 0% <ø> (ø) 4 <0> (-2) ⬇️
src/Elements/ElementFeatures.php 77.77% <100%> (+11.11%) 5 <1> (ø) ⬇️
src/Elements/ElementPromos.php 27.08% <100%> (-4.29%) 16 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17069c1...4d2680d. Read the comment docs.

@jsirish jsirish merged commit 09dc1bf into dynamic:master Oct 27, 2017
@jsirish jsirish deleted the bugfix/promosTemplate branch October 27, 2017 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant