Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Version of recipe for 4.2 #13

Merged
merged 1 commit into from Aug 9, 2018
Merged

Conversation

gordonbanderson
Copy link
Contributor

The version of recipe-cms effectively pinned this repo to 4.1 when I tried to upgrade. Not sure if this is the best way to fix it, and it will need a major version bump in packagist as it's not backwards compatible to 4.1.

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #13   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       16     16           
=======================================
  Files             3      3           
  Lines            43     43           
=======================================
  Hits             43     43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcc9f2...dd79b39. Read the comment docs.

@muskie9
Copy link
Member

muskie9 commented Aug 8, 2018

Hi @gordonbanderson, thanks for the PR! We've run through some installation tests and the update made would lock this module into only using recipe-cms: 4.2.1. Could you update the version constraints to the following, it should keep backwards compatibility for existing installations as well as anything at or above the 4.0.0 tags.

"silverstripe/recipe-cms": "^1.0 || ^4.0"

@gordonbanderson
Copy link
Contributor Author

Change made as requested, I've force pushed so only one commit in the history. Seems to work running composer update and version control pointing at this PR in composer.json.

Thanks for educating me on the use of || in version control restraints, that is useful :)

@muskie9
Copy link
Member

muskie9 commented Aug 9, 2018

Thanks for making the update. We brushed up on the options a while back when we noticed the version change for the recipe.

@muskie9 muskie9 merged commit c6ca2c5 into dynamic:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants