Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR Purchasable - getIsAvailable - allow extension #111

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Aug 8, 2020

overhaul tests

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #111 into master will increase coverage by 0.15%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
+ Coverage     53.00%   53.15%   +0.15%     
- Complexity      238      241       +3     
============================================
  Files            13       13              
  Lines           883      888       +5     
============================================
+ Hits            468      472       +4     
- Misses          415      416       +1     
Flag Coverage Δ Complexity Δ
#php 53.15% <63.63%> (+0.15%) 241.00 <0.00> (+3.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Extension/Purchasable.php 87.28% <63.63%> (-0.33%) 26.00 <0.00> (+3.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79bf75...32d2423. Read the comment docs.

@jsirish jsirish merged commit f6b8eb5 into dynamic:master Aug 8, 2020
@jsirish jsirish deleted the feature/availableExtension branch August 8, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant