Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code trimming for product and option codes #90

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Mar 24, 2020

Resolves #86
Resolves #77

@mak001 mak001 requested review from muskie9 and jsirish March 24, 2020 16:04
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #90 into 1.0 will increase coverage by 0.22%.
The diff coverage is 43.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.0      #90      +/-   ##
============================================
+ Coverage     62.29%   62.51%   +0.22%     
- Complexity      194      204      +10     
============================================
  Files            11       11              
  Lines           724      763      +39     
============================================
+ Hits            451      477      +26     
- Misses          273      286      +13     
Flag Coverage Δ Complexity Δ
#php 62.51% <43.33%> (+0.22%) 204.00 <6.00> (+10.00)
Impacted Files Coverage Δ Complexity Δ
src/Extension/Shippable.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Model/FoxyCategory.php 71.11% <ø> (ø) 15.00 <0.00> (ø)
src/Model/OptionType.php 82.35% <ø> (ø) 7.00 <0.00> (ø)
src/Model/ProductOption.php 62.11% <30.43%> (-4.33%) 40.00 <4.00> (+8.00) ⬇️
src/Extension/Purchasable.php 91.00% <83.33%> (+0.67%) 21.00 <2.00> (+1.00)
src/Model/Setting.php 86.84% <100.00%> (+1.12%) 25.00 <0.00> (ø)
src/Form/AddToCartForm.php 65.21% <0.00%> (+1.30%) 37.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e312ae6...0b4109a. Read the comment docs.

Copy link
Member

@jsirish jsirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mak001 mak001 merged commit eb0dc5c into dynamic:1.0 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants