Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionProvider - consolidate to MANAGE_JOBS permission #15

Merged
merged 3 commits into from May 3, 2019

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented May 2, 2019

initial i18n work

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #15 into master will decrease coverage by 1.95%.
The diff coverage is 89.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #15      +/-   ##
===========================================
- Coverage     92.56%   90.6%   -1.96%     
- Complexity       61      64       +3     
===========================================
  Files             8       8              
  Lines           269     330      +61     
===========================================
+ Hits            249     299      +50     
- Misses           20      31      +11
Impacted Files Coverage Δ Complexity Δ
src/Model/JobSection.php 100% <100%> (ø) 8 <1> (+1) ⬆️
src/Model/JobSubmission.php 100% <100%> (ø) 12 <1> (+1) ⬆️
src/Model/JobCategory.php 100% <100%> (ø) 7 <1> (+1) ⬆️
src/Page/Job.php 75.92% <80.39%> (-5.09%) 15 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a05bc6...00d3938. Read the comment docs.

@jsirish jsirish merged commit cb2d9ba into dynamic:master May 3, 2019
@jsirish jsirish deleted the feature/i18n branch May 3, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant