Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a schema for products #100

Merged
merged 3 commits into from Jul 23, 2021
Merged

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Jul 23, 2021

discussed in #39

currency is currently hardcoded as USD
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #100 (45d2674) into master (280eab2) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
- Coverage     14.89%   14.49%   -0.41%     
- Complexity      273      282       +9     
============================================
  Files            15       16       +1     
  Lines           933      959      +26     
============================================
  Hits            139      139              
- Misses          794      820      +26     
Flag Coverage Δ
unittests 14.49% <0.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Client/ShopifyClient.php 0.00% <0.00%> (ø)
src/Page/ShopifyProduct.php 60.75% <ø> (ø)
src/SEO/ProductSchemaBuilder.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280eab2...45d2674. Read the comment docs.

  - stored in site config
  - updated automatically when a fetch occurs
@mak001 mak001 merged commit a94cef6 into dynamic:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant