Feature: Add config variable to list provinces before states #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have added to the tests to track this feature, but the version of phpunit included does not run in php 8.x. |
jsirish
force-pushed
the
feature-provinces-first
branch
from
f699376
to
45f6de2
Compare
|
@davejtoews thanks for the PR! I've made some updates to the module and rebased your branch. If you still wanted to do write tests, PHPUnit and GitHub Actions are now working. |
|
@jsirish tests have now been added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating forms for primarily Canadian users it makes sense to list provinces before US states, rather than after. Without this PR I can only do this by feeding the entire list into $default_states or getStates().
This PR allows setting
states_first: falseto invert the order. It also adds a config value forinclude_provincesas I presume in most cases a site will configure all instances of the field the same way.