CLN: Remove default name for a new axis

dynamicslab · Jan 5, 2024 · 341f15c · 341f15c
1 parent 62d12ea
commit 341f15c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/pysindy/utils/axes.py b/pysindy/utils/axes.py
@@ -123,8 +123,7 @@ def remove_axis(self, axis: Union[Collection[int], int, None] = None):
                 new_axes[ax_dec_name].append(old_ax_dec - 1)
         return self._compat_axes(new_axes)
 
-    # TODO: delete default kwarg value
-    def insert_axis(self, axis: Union[Collection[int], int], new_name: str = "ax_unk"):
+    def insert_axis(self, axis: Union[Collection[int], int], new_name: str):
         """Create an axes dict from self with specified axis or axes
         added and all greater axes incremented.
 

diff --git a/test/utils/test_axes.py b/test/utils/test_axes.py
@@ -383,7 +383,7 @@ def test_insert_multiple_AxisMapping():
         },
         6,
     )
-    result = ax_map.insert_axis([1, 4])
+    result = ax_map.insert_axis([1, 4], new_name="ax_unk")
     expected = {
         "ax_a": [0, 2],
         "ax_unk": [1, 4],
@@ -404,7 +404,7 @@ def test_insert_misordered_AxisMapping():
         },
         6,
     )
-    result = ax_map.insert_axis([4, 1])
+    result = ax_map.insert_axis([4, 1], new_name="ax_unk")
     expected = {
         "ax_a": [0, 2],
         "ax_unk": [1, 4],