BUG: SINDyDerivative set_params() missed sklearn interface #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was resulting in:
```
> self.kwargs
{"kind": "spline", "s": .01, "kwargs":{"kind": finitedifference, "k": 1}}
```
This is because set_params has to mimic the exact functionality of __init__.
See https://scikit-learn.org/stable/developers/develop.html#parameters-and-init
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 33 33
Lines 3297 3297
=======================================
Hits 3092 3092
Misses 205 205
Continue to review full report at Codecov.
|
jpcurbelo
pushed a commit
to jpcurbelo/pysindy_fork
that referenced
this pull request
Apr 30, 2024
BUG: SINDyDerivative set_params() missed sklearn interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a bug in how
SINDyDerivativemade a mistake withset_params(). Previously, CV test was passing, but silently not updating parameters the way it should have. See commit msg