Simpler inputs #362
Merged
Simpler inputs #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove inputs_per_library as it's not in function signature.
Reorder feature and parameter kwargs to match signature
Removed explicit attributes, referenced superclass IAW PEP 257
Removed include_bias=True from parameter_lib default - include_bias is true by
default
Annotated types
Add escape hatch in GeneralizedLibrary so old-style arrays work (but are warned)
Also:
* unique elements of a list that preserves order requires an idiom, so I've
extracted it to its own function. do we want sorted()?
* Add more type annotations
* the following sklearn API fixes to generalized_library:
Remove attribute when has same name as parameter in docstrings
Remove trailing underscore on hyperparamters
Do not set trailing underscore on fitted parameters in __init__ (breaks
check_if_fitted)
With removal of legacy ensembling, only feature libraries that inherit a non-trivial init are ParameterizedLibrary and PolynomialLibrary
Jacob-Stevens-Haas
force-pushed
the
simpler-inputs
branch
from
c459660
to
93b6720
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
==========================================
- Coverage 93.95% 93.70% -0.26%
==========================================
Files 37 37
Lines 3688 3589 -99
==========================================
- Hits 3465 3363 -102
- Misses 223 226 +3
☔ View full report in Codecov by Sentry. |
jpcurbelo
pushed a commit
to jpcurbelo/pysindy_fork
that referenced
this pull request
Apr 30, 2024
Simpler inputs_per_library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Only thing to consider is whether we want to enforce sorted inputs_per_library. I maintained current behavior in cases, where
might cause some nonsensical behavior, since
arr[[2,0]] != arr[[0,2]], but also might make no difference since it applies the same to feature names. Can easily change this to automatically sort inputs if people want.