Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to enable intersphinx mapping to sklearn #363

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Jacob-Stevens-Haas
Copy link
Collaborator

@Jacob-Stevens-Haas Jacob-Stevens-Haas commented Jul 4, 2023

Sphinx reads the public methods of all classes, and if one inherits from sklearn, it reads that method's docstring. If that method contains a relative link in the rst, sphinx needs to know where to link it.

This will fix the current CI failure, new as of scikit-learn 1.3. I'm going to give this a suspense time of a day in case anyone wants to read it, but its a hotfix blocking any PR's CI so I want to move it fast.

Sphinks reads the public methods of all classes, and if one inherits from
sklearn, it reads that method's docstring.  If that method contains a relative
link in the rst, sphinx needs to know where to link it.
@Jacob-Stevens-Haas
Copy link
Collaborator Author

Jacob-Stevens-Haas commented Jul 5, 2023

There appear to be more failures from scikit-learn-1.3.0, released June 30th, dealing with sparse matrices.

@Jacob-Stevens-Haas Jacob-Stevens-Haas merged commit 1e5b99f into master Jul 6, 2023
2 of 4 checks passed
@Jacob-Stevens-Haas Jacob-Stevens-Haas deleted the intersphinx branch July 6, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant