(Much) Faster tests 🐎 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Shrink test data * set very accepting relative tolerance in integration
As these just assert that a model is fitted, we can trim excess work: * shrink lorenz test data * remove duplicate lines * no separate test needed for normalize_columns (only handled in BaseOptimizer)
Also test just the optimizer, not the whole SINDy pipeline Cuts this test duration, previously the longest, by 95%
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 93.87% 93.73% -0.14%
==========================================
Files 37 37
Lines 3590 3590
==========================================
- Hits 3370 3365 -5
- Misses 220 225 +5 ☔ View full report in Codecov by Sentry. |
jpcurbelo
pushed a commit
to jpcurbelo/pysindy_fork
that referenced
this pull request
Apr 30, 2024
(Much) Faster tests 🐎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #320