Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property test for optimizers complexity #55

Merged
merged 1 commit into from Mar 8, 2020

Conversation

Ohjeah
Copy link
Collaborator

@Ohjeah Ohjeah commented Mar 8, 2020

This add the suggested by @sixpearls in review openjournals/joss-reviews#2104

The test uses hypothesis and sklearns make_dataset to construct a random regression dataset and verifies that less regularized optimizers are more complex.

@Ohjeah Ohjeah requested a review from briandesilva March 8, 2020 19:46
Copy link
Member

@briandesilva briandesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test! I had not heard of the hypothesis package before, but it seems especially useful here.

@briandesilva briandesilva merged commit 2424356 into master Mar 8, 2020
@briandesilva briandesilva deleted the mq/add_property_test branch March 8, 2020 22:27
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this pull request Apr 30, 2024
Add property test for optimizers complexity
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this pull request May 9, 2024
* Add support for multiple netcdf datasets

* Add forcing information to second netcdf warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants