skip mix dynamo.filters if Mix.project[:dynamos] is not defined #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
pushed a commit
that referenced
this pull request
Oct 15, 2013
skip mix dynamo.filters if Mix.project[:dynamos] is not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"mix dynamo.filters" on original dynamo project fails with the "Protocol.UndefinedError".
It would not be a valid scenario (it should be executed for a project created by "mix dynamo"), but it's nice to just skip the task processing if there's nothing to be displayed?
% git clone https://github.com/elixir-lang/dynamo
% cd dynamo
% mix deps.get
% mix compile
% mix dynamo.filters
** (Protocol.UndefinedError) protocol Enumerable not implemented for nil
/Users/knakase/tmp/github/elixir/lib/elixir/lib/enum.ex:1: Enumerable.impl_for!/1
/Users/knakase/tmp/github/elixir/lib/elixir/lib/enum.ex:37: Enumerable.reduce/3
/Users/knakase/tmp/github/elixir/lib/elixir/lib/enum.ex:354: Enum.each/2
/Users/knakase/tmp/github/elixir/lib/mix/lib/mix/project.ex:153: Mix.Project.recur/2
/Users/knakase/tmp/github/elixir/lib/mix/lib/mix/task.ex:167: Mix.Task.run/2
/Users/knakase/tmp/github/elixir/lib/mix/lib/mix/cli.ex:61: Mix.CLI.run_task/2