Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make views & visibility more generic and consistent #125

Closed
radumg opened this issue Aug 14, 2019 · 1 comment · Fixed by #126
Closed

Make views & visibility more generic and consistent #125

radumg opened this issue Aug 14, 2019 · 1 comment · Fixed by #126
Assignees
Labels
enhancement An improvement to current functionality or codebase feedback refactor Cleanup and refactor of existing solution.

Comments

@radumg
Copy link
Collaborator

radumg commented Aug 14, 2019

Following the London workshops we organised, a few customers noted that the Analyze nodes for VisiblePoints and ViewsToOutside especially could

  • be more generic
  • have better naming of ports
  • have more clear & useful outputs
Feedback Node
Input: viewSegment > Target ViewsToOutside
Name: Use more generic naming. ViewsToOutside
Internals should be obstructions ViewsToOutside
Not sure about the score, it is not necessarily a score. It is more like an angle of view or field of view. They assume the score is the percentage of windows that can be seen. Maybe leave the score out of the outputs. ViewsToOutside
Report how much of the windows they can actually see, in length or area or percentage. ViewsToOutside
ByLineSegments, are those the windows or the obstructions
@radumg radumg added enhancement An improvement to current functionality or codebase refactor Cleanup and refactor of existing solution. feedback labels Aug 14, 2019
@radumg radumg added this to the Feedback improvements milestone Aug 14, 2019
@radumg radumg self-assigned this Aug 14, 2019
@radumg
Copy link
Collaborator Author

radumg commented Aug 14, 2019

Proposed changes

  • merge ViewsToOutside & VisiblePoints categories into one : Visibility
  • change names of nodes to make sense in this new organisation
  • change port names to make more generic and usable, as per feedback above : internals>obstructions, viewsToOutside>viewsToTarget
  • change scoring to percentages rather than [0,1] values

@radumg radumg changed the title Make port naming for views & visibility more consistent Make views & visibility more generic and consistent Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to current functionality or codebase feedback refactor Cleanup and refactor of existing solution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant