-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0 Rewrite #709
Comments
Thank you for your excellent library, I has been using the version 2.0 and created the |
@fishcharlie Great work! Really looking forward for v2 and will try it out together with the NestJS module :) What do you think about using TypeScript decorators for everything? Like TypeORM or dynamo-types does? I wonder why v2 is not made in TypeScript in general? :) @hardyscc I just started a new Nest app with DynamoDB and saw your comment randomly, thats awesome! Could you try to get you module into the Nest docs for all others to come? |
@MickL I just released this nest module in very short time to fulfil my need, still have many missing pieces. I am waiting Dynamoose 2.0 to come out first and will definitely notify the nest community soon. thanks :) |
@hardyscc Awesome!!! Glad it worked well for you. If you have any other feedback or suggestions, please let me know. |
@MickL I'm the main contributor to Dynamoose at this point, and I have never used TypeScript to date. It is on my list of things to work on. Maintainability is a massive priority for Dynamoose v2. I'm unwilling at this point to jump into a new technology on this project when I don't feel comfortable and confident with it. I believe Dynamoose v2 really prepares for an easy migration to refactoring to use TypeScript sometime soon. It just comes down to my level of prioritization, and I have chosen to prioritize things like documentation, test coverage, bug fixes, and code maintainability, over TypeScript. I believe that is reflected in the work I have done with v2. As mentioned in the Goals section above Hopefully that helps clear up that question and gives some insight into my thinking regarding this. |
Sounds good and I can totally understand especially when it comes to documentation, test coverage and bug fixes. |
Version 2.0 Rewrite
Summary:
This issue tracks the full rewrite of Dynamoose for version 2.0.
Last Steps Before Final:
Next Steps:
dynamoose.undefined
based on comments in dynamoose.undefined #726errorUnknown
Schema setting from Dynamoose v1update
optionallowEmptyArray
setting for Model.updatecreateRequired
setting for Model.updatereturnValues
setting for Model.updateexpires/ttl
other than adding a property to the Schemautils/empty_function.js
from code coverage summary afternpm test
UnprocessedKeys
in batchGetrangeKey
&hashKey
should truly be on the Schema like v1, since it only gets set per Table, maybe it should be on the Model.Long term steps:
updateDetails
timeout forupdateTimeToLive
. We should also maybe refactor how the setup flow works. We are doing a bunch of different things, and in a lot of cases we retrieve data before running a check function. We should standardize that process to make the code more dry.JSON.stringify(test.schema)
throughout the test suite, it prints{}
, we need to figure out how to fix thisv2.x Tasks:
Model.populate
null
DynamoDB typeModel.update
)moment
bignumber.js
Goals:
Other Notes:
News/Announcements:
2.0
branch.The text was updated successfully, but these errors were encountered: