Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating with saveUnknown enabled #404

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Updating with saveUnknown enabled #404

merged 1 commit into from
Sep 28, 2018

Conversation

fishcharlie
Copy link
Member

@fishcharlie fishcharlie commented Aug 3, 2018

Summary:

This PR is adding a test for a related issue that needs to be fixed. Currently updating with saveUnknown enabled fails silently, and doesn't update with unknown properties.

GitHub linked issue:

#403

Type (select 1):

Is this a breaking change? (select 1):

  • 馃毃 YES 馃毃
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have run npm test from the root of the project directory to ensure all tests continue to pass
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have filled out all fields above

@fishcharlie fishcharlie mentioned this pull request Aug 3, 2018
11 tasks
@fishcharlie fishcharlie merged commit 19821de into dynamoose:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant